Re: Getting path...


"McKirahan" <News@xxxxxxxxxxxxx> wrote in message
news:Wbednf4CW6SlMhLfRVn-og@xxxxxxxxxxxxxx
> "Al Dunbar [MS-MVP]" <alan-no-drub-spam@xxxxxxxxxxx> wrote in message
> news:Ok1WPwhXFHA.3728@xxxxxxxxxxxxxxxxxxxxxxx
>
> [snip]
>
> > Most of the scripts I write that deal with files have enough to do with
> them
> > that an instance of the file system object is required anyway.
> >
> > > And it returns the filename not the path.
> >
> > Oops, I misread the post, and should have used this instead:
> >
> > sPath = FSO.getParentFolderName(sPath)
> >
> > I also find that relying on its path parsing methods results in a little
> > more consistency and readability in my code. You probably took less time
> to
> > realise that .getFileName was the wrong method in this case than I took
to
> > come to the (incorrect) conclusion that it was. I made the mistake
because
> > the intent of the following expression is not as explicit:
> >
> > sPath = Left(sPath,InStrRev(sPath,"\"))
> >
> > It will also fail in the event that the elements of a pathname are
> delimited
> > with "/" instead of "\", as is common in URLs.
> >
> > /Al
> >
> >
>
> "torgeir" already posted a "getParentFolderName" solution.
>
> The post asked about the full name of a script not a URL;
> thus, "\" is applicable and "/" is not.

Given that the path name itself comes from a call that we know is going to
return "\", the code works. In that context, yes, you are right.

But that does not make using getParentFolderName any less of a correct
solution as a result. The file system accepts paths using "/" instead of
"\", and the same operations may need to be done on URL's in another script.
My recommendation for my approach is that, should one happen to need to work
with URL's, fewer changes would need to be made to accommodate. This isn't
robustness for the sake of code robustness, but robustness for the sake of
the coder.

> I agree that the meaning
> sPath = Left(sPath,InStrRev(sPath,"\"))
> is not very explicit; however, looking at all three lines
>
> Dim sPath
> sPath = WScript.ScriptFullName
> sPath = Left(sPath,InStrRev(sPath,"\"))
>
> does suggest that the Path is extracted from the Name.

Yes, however one needs to exert more brain cells to see the meaning.

> Anyway, the intention of lots of code isn't always clear which is
> why meaningful variable names and comments are often used.

I cannot agree with you more on that one. Which is why I generally use
variable names that are more meaningful than sPath and include suitable
comments. In my case, at least, I find I can even improve things by using
methods whose names are also descriptive, at least where the situation
allows for this.

/Al


.

Relevant Pages

  • Re: notice and warning
    ... that script lists, edits, deletes users. ... That's just a broken design. ... POST and GET _do_ have a totally different meaning, ... keep your application safe just for the sake of using $_REQUEST. ...
    (comp.lang.php)
  • Re: Question about CSS definitions
    ... A class should reflect the meaning of the content which it is applied ... I change the template which is used to build the HTML. ... By script. ...
    (alt.html)
  • Re: Aspiring highest-order programmer
    ... > that outputs its own script text. ... I think what you may not be seeing is that any single assembler program ... strong parallels between lambda forms and Platonic objects. ... So, point is, sets have no meaning in themselves. ...
    (comp.programming)
  • Re: Sending email problem with Windows 2000 professional
    ... is the loopback address of the local machine, meaning you're ... saying Flds= [This computer that is running this script.] ...
    (microsoft.public.inetserver.asp.general)
  • Re: Can we use variables in XL macros?
    ... DIM sPath as String ... AutoIt, a freeware scripting language. ... One of the very cool features ... The advantage of the above is that it's easy to make a script that you ...
    (microsoft.public.excel.programming)