Re: no static functions in WDK examples;

It is OK to use static functions, however it might not be advisable to do
so. If you have a driver released to millions of customers and all you get
for most dumps is just a minidump, how do you locate the function where you
were last processing? Yes, a map file can help, but it makes it much more
of a manual process where you have to get the map file for the version the
dump reflects as running. Then you have to do the math to locate the
function. You also end up with a lot of dumps logged against your exposed
function when it really is not that function that was involved. Also having
a symbol server helps but unless you release a full symbol PDB to
Microsoft's OCA system it will still require you to download the dumps and
check them with windbg.

If you have functions you prefer to keep confidential then the above advise
may not apply. If you have such a function, I would recommend that you call
any outside function from one of those you do it through a public function.
It just makes the stacks easier to follow. I have been in two places where
having a lot of dumps even though the number of bugs attributable to the
company's code was actually very few.

As each new release hits the world monitoring OCA at Microsoft is a wise
investment. Having someone in QA checking every week for patterns is a good
thing to do. Sometimes there are a class of crashes that while OCA gives
them to you, are really in other components. Microsoft has a bias in the
OCA analysis that looks for drivers other than Microsoft's to assign the
bug. If you get hold of Microsoft you can get them moved so the real
problem can be found.


"pradeep bisht" <pradeep_bisht@xxxxxxxxx> wrote in message
news:79baff43-8a4b-458c-84cc-11d208f972b6@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thanks Don for replying even though I just realized that I posted to
the wrong list instead of posting to the driver's list :(.

So it is OK to use static.

On Jun 14, 1:29 pm, "Don Burn" <b...@xxxxxxxxxxxxxxxxxxxx> wrote:
Comments inline:

"pradeep bisht" <pradeep_bi...@xxxxxxxxx> wrote in message

news:b2b4c37c-b61c-4ef7-8a2f-00c014eff55e@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

I don;t see any "static" functions in WDK examples. Even though there
are functions which are used inside only one file. Generally if a 'c'
function local to a file is declared static. Is there a technical
reason for not using static?
[I'm new to driver development so may this question is stupid.]

There is no technical reason not to. Personally, I hve always found
this
frustratng since there is no reason not to make things static.



Are there any general guidelines for writing drivers (disk filter
drivers, to be more specific). Thanks.

Also how can I compare two MULTI_REG_SZ buffers returned by
IoGetDeviceProperty when called for DevicePropertyHardwareID?
Currently I'm just comparing each character (in a for loop) upto
ResultLength returned by IoGetDeviceProperty.

for (i = 0; i < propertyLength; i++) {
if (myHardWareID[i] != propertyBuffer[i]) {
break;
}
}

if (i != propertyLength) {
DebugPrint ("Not matched");
}

For the compare use:

if ( propertyLength != RtlCompareMemory( myHardWareID,
propertyBuffer,
propertyLength) ) {
DebugPrint ("Not matched");
}

--
Don Burn (MVP, Windows DDK)
Windows 2k/XP/2k3 Filesystem and Driver Consulting
Website:http://www.windrvr.com
Blog:http://msmvps.com/blogs/WinDrvr
Remove StopSpam to reply



.

Relevant Pages

  • Re: no static functions in WDK examples;
    ... information for their products to OCA? ... Windows 2k/XP/2k3 Filesystem and Driver Consulting ... You also end up with a lot of dumps logged ... There is no technical reason not to. ...
    (microsoft.public.win32.programmer.kernel)
  • Re: Alonso confirmed at Ferrari
    ... I notice you can't refute what I posted. ... "So every driver that ever leaves a team "dumps" it? ... show me where I've said that every driver that leaves a team ... whether it was his fault, Lewis' fault, Ron's fault, whatever). ...
    (rec.autos.sport.f1)
  • Re: no static functions in WDK examples;
    ... Windows 2k/XP/2k3 Filesystem and Driver Consulting ... Yes, a map file can help, but it makes it ... You also end up with a lot of dumps logged against ... As each new release hits the world monitoring OCA at Microsoft is a wise ...
    (microsoft.public.win32.programmer.kernel)
  • Re: Alonso confirmed at Ferrari
    ... "So every driver that ever leaves a team "dumps" it? ... whether it was his fault, Lewis' fault, Ron's fault, whatever). ... And in answer to your last paragraph, no, Barrichello isn't dumping ...
    (rec.autos.sport.f1)
  • Re: Alonso confirmed at Ferrari
    ... "So every driver that ever leaves a team "dumps" it? ... whether it was his fault, Lewis' fault, Ron's fault, whatever). ... seriously suggesting that it was possible to stay on at McLaren and sort ...
    (rec.autos.sport.f1)