Re: Compiler bug in the DDK--be aware of it

I am new to driver development. Can you actually build drivers with
the visual studio 2005 C compiler, or did you compile that piece of
code just to show the bug in the DDK build environment?


440gtx@xxxxxxxxx wrote:
Hi guys, I ran into a compiler bug in the latest ddk that is very
serious. I have a piece of code I want to execute exactly one time, but
discovered it gets run every single time. It is written as follows:


void func(void)
{
static LONG Init = 0;

if (InterlockedOr(&Init, 1) == 0)
{
...do one time stuff here...
}
}


The problem is the inner code executes every single time the function
is invoked. I traced it down to a bug in the compiler. I then
recompiled the driver using the Visual Studio 2005 compiler and the
problem was fixed. I have attached the code each generated below. I'm
now concerned about shipping any future drivers compiled using the DDK
build environment because I don't know what all functions besides this
particular example would generate corrupt code.



;------------------------------------;
; Windows 2003 DDK SP1 (3790.1830)
;------------------------------------;
mov ecx, 1
mov edx, OFFSET FLAT:?Init
mov eax, DWORD PTR [edx]
$L14033:
mov esi, eax
or esi, ecx
lock cmpxchg DWORD PTR [edx], esi
jne $L14033
jne $L14011

;------------------------------------
; Visual Studio 2005
;------------------------------------
mov ecx, 1
mov edx, OFFSET ?Init
mov eax, DWORD PTR [edx]
$LN4
mov esi, eax
or esi, ecx
lock cmpxchg DWORD PTR [edx], esi
jne SHORT $LN4
test eax, eax ; <---------fixed
jne SHORT $LN2

.

Relevant Pages

  • Re: Compiler bug in the DDK--be aware of it
    ... No one ever said that the DDK compiler was perfect, ... only supported compiler for device driver development. ... mov edx, OFFSET FLAT:?Init ... mov esi, eax ...
    (microsoft.public.development.device.drivers)
  • lucent modem driver compilation failure
    ... I'm trying to compile an installable module for my internal modem ... and driver work as they were fully functional under RH7.3. ... 00:07.2 USB Controller: VIA Technologies, ... If not present use the ltmodem-8.22a5.tar.gz compiler kit. ...
    (linux.redhat.misc)
  • lucent modem driver compilation failure
    ... I'm trying to compile an installable module for my internal modem ... and driver work as they were fully functional under RH7.3. ... 00:07.2 USB Controller: VIA Technologies, ... If not present use the ltmodem-8.22a5.tar.gz compiler kit. ...
    (comp.os.linux.hardware)
  • Re: compiler generated output
    ... compiler to generate code which only uses 386 instruction). ... Thus, while replacing mov/and with movzx, the jump is still there. ... 00000001`00001c65 66894c2408 mov,cx ...
    (comp.lang.asm.x86)
  • Re: Maybe we should stop "Paging Beth Stone" already...
    ... So in my OS, you'd have a keyboard port, mouse port, and video card driver which just did the actual hardware interfacing, and nothing else. ... # See if piece matches push edi lea esi, mov ecx,; inc ecx # include the null character repz cmpsb pop edi leave ... mov eax, ...
    (alt.lang.asm)